test(e2e): enable pipelining on bot, fees, and avm simulator tests#23329
Open
spalladino wants to merge 3 commits into
Open
test(e2e): enable pipelining on bot, fees, and avm simulator tests#23329spalladino wants to merge 3 commits into
spalladino wants to merge 3 commits into
Conversation
spalladino
added
the
ci-no-fail-fast
ludamad
force-pushed
the
merge-train/spartan
branch
from
4af2626 to
db4ec58
Compare
ludamad
requested review from
IlyasRidhuan,
LHerskind,
Maddiaa0,
MirandaWood,
jeanmon and
just-mitch
as code owners
Prevents errors when simulating public calls in the node JSON RPC API that occur when simulating after a checkpoint has been closed but before the L2 slot is finished so the inbox is not yet sealed. See also A-1063
Opts e2e_avm_simulator, e2e_bot, e2e_fees/private_payments, and e2e_fees/failures into proposer pipelining via PIPELINING_SETUP_OPTS. The simulatePublicCalls fix in 1b11032 handles the L1ToL2 inbox-lag mismatch that previously blocked these suites. aztecProofSubmissionEpochs is bumped to 640 to avoid the unproven-epoch auto-prune during long runs (none of these suites care about reorgs). The transaction-bot config also bumps minFeePadding to PIPELINED_FEE_PADDING since the bot overrides the wallet padding via wallet.setMinFeePadding.
spalladino
force-pushed
the
spl/pipelining-on-sim-tests
branch
from
0db9a47 to
ccff639
Compare
spalladino
removed request for
IlyasRidhuan,
LHerskind,
Maddiaa0,
MirandaWood,
jeanmon and
just-mitch
…all-clock under pipelining e2e_avm_simulator: split AvmTestContract into 'shared deployment' and 'fresh deployment per test' sub-describes. 12 read-only tests now share a single avmContract deployed in beforeAll; 9 mutating tests (storage, nullifier emits, the two two-contract nullifier collision tests) still redeploy in beforeEach. Net contract deploys in AvmTestContract drop from 42 to 20, shaving ~5 min of slot-paced deploy time off the file. e2e_bot.test.ts: lower 'creates bot after inbox drift' drift from 10 to 4 checkpoints. The sibling l1_to_l2 drift test already uses 4 and 4 is enough to exceed inboxLag=2 and exercise the inbox-far-ahead-of-rollup path. Saves ~2 min of wall-clock waiting for the inbox tree to be consumable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opts four e2e suites into proposer pipelining now that the
simulatePublicCallsinbox-lag mismatch is fixed in 1b11032 ("fix(node): Do not fail public call simulation if inbox is not sealed"):e2e_avm_simulatore2e_bote2e_fees/private_paymentse2e_fees/failuresEach test gets
PIPELINING_SETUP_OPTSplusaztecProofSubmissionEpochs: 640to avoid the unproven-epoch auto-prune during long runs (none of these suites care about reorgs). Thetransaction-botconfig also bumpsminFeePaddingtoPIPELINED_FEE_PADDINGsince the bot overrides the wallet padding viawallet.setMinFeePadding(config.minFeePadding)inbot/src/factory.ts:60.